Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy PACKAGE.py files #2221

Closed
egede opened this issue Dec 7, 2023 · 5 comments
Closed

Remove legacy PACKAGE.py files #2221

egede opened this issue Dec 7, 2023 · 5 comments

Comments

@egede
Copy link
Member

egede commented Dec 7, 2023

In the different plugins of Ganga there is a PACKAGE.py that back in ancient history defined dependencies. I believe the files themselves and the loading of them and subsequent creation of of instances of the PackageSetup class can all be deleted.

./GangaCore/PACKAGE.py
./GangaDirac/PACKAGE.py
./GangaGaudi/PACKAGE.py
./GangaLHCb/PACKAGE.py
./GangaND280/PACKAGE.py
./GangaTest/Lib/GListApp/PACKAGE.py
./GangaTest/Lib/TFile/PACKAGE.py
./GangaTest/PACKAGE.py
./GangaTutorial/PACKAGE.py
@souravpy
Copy link
Contributor

I would love to pick up the issue, can I know where are PackageSetup class defined, so that I can delete them along with afore mentioned PACKAGE.py files. Thank you !!

@egede
Copy link
Member Author

egede commented Dec 31, 2023

Just check in the import statements where it is located. Or do a search across the source code.

Thanks for considering fixing this.

@souravpy
Copy link
Contributor

souravpy commented Jan 2, 2024

Should I deletePackageSetupclass across the source code or should we avoid subsequent creations of the class?

@souravpy
Copy link
Contributor

souravpy commented Jan 2, 2024

PR deleting all PACKAGE.py files #2247

@mesmith75
Copy link
Contributor

Fixed by #2247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants