Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileChecker has not attribute 'order' #402

Closed
graipher opened this issue Apr 22, 2016 · 7 comments
Closed

FileChecker has not attribute 'order' #402

graipher opened this issue Apr 22, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@graipher
Copy link

graipher commented Apr 22, 2016

While trying to implement the workaround mentioned by @drmarkwslater in GANGA-385, I am running into this error with FileChecker:

Traceback (most recent call last):
  File "/afs/cern.ch/lhcb/software/releases/GANGA/GANGA_v601r18/install/ganga/bin/ganga", line 69, in <module>
    Ganga.Runtime._prog.run()
  File "/afs/cern.ch/lhcb/software/releases/GANGA/GANGA_v601r18/install/ganga/python/Ganga/Runtime/bootstrap.py", line 1234, in run
    execfile(script, local_ns)
  File "./submit.py", line 105, in <module>
    j.postprocessors.append(pp)
  File "/afs/cern.ch/lhcb/software/releases/GANGA/GANGA_v601r18/install/ganga/python/Ganga/GPIDev/Adapters/IPostProcessor.py", line 89, in append
    self.process_objects, key=lambda process: process.order)
  File "/afs/cern.ch/lhcb/software/releases/GANGA/GANGA_v601r18/install/ganga/python/Ganga/GPIDev/Adapters/IPostProcessor.py", line 89, in <lambda>
    self.process_objects, key=lambda process: process.order)
  File "/afs/cern.ch/lhcb/software/releases/GANGA/GANGA_v601r18/install/ganga/python/Ganga/GPIDev/Base/Proxy.py", line 1016, in _getattribute
    returnable = GPIProxyObject.__getattribute__(self, name)
AttributeError: 'FileChecker' object has no attribute 'order'

Corresponding code in my submission script:

postprocessors = [
        FileChecker(files=['stdout'], searchStrings=['INFO Application Manager Terminated successfully'], failIfFound=False, checkMaster=False)]
if args.evtmax < 0:
    postprocessors.append(LHCbCompleteChecker())
    if all(isinstance(f, LogicalFile) for f in j.inputdata):
        postprocessors.append(LHCbBookkeepingChecker())
for pp in postprocessors:
        j.postprocessors.append(pp)
@milliams
Copy link
Contributor

This is being caused by a proxied object getting though the proxy layer. It should be fixed with #393 but we'll have to run some tests.

@milliams milliams added the bug label Apr 22, 2016
@milliams milliams added this to the 6.1.19 milestone Apr 22, 2016
@graipher
Copy link
Author

graipher commented Apr 22, 2016

OK, thanks.
BTW when is 6.19 expected to be released/when can I at least easily test it with SetupProject Ganga --dev v601r19?

@rob-c
Copy link
Member

rob-c commented Apr 22, 2016

Due to not wanting to have to support branches in various different stages of development we're not providing Ganga in the dev area between releases for every release.
To install it yourself from git see: http://ganga.readthedocs.org/en/latest/UserGuide/InstallAndBasicUsage.html

If you need some help feel free to send a pm after trying to install it

@alexanderrichards alexanderrichards modified the milestones: 6.1.20, 6.1.19 Apr 28, 2016
@milliams milliams self-assigned this May 5, 2016
@milliams
Copy link
Contributor

@graipher I am unable to reproduce this in 6.1.19. Do you have a minimal reproducible example which I can test against? LHCbCompleteChecker and LHCbBookkeepingChecker are not Ganga classes.

@graipher
Copy link
Author

Hey @milliams,
I can also not reproduce this anymore in 6.1.19, with these custom classes.
Maybe it was fixed by whatever fixed #270?

@graipher
Copy link
Author

Also, before already FileChecker (which is an official Ganga class, right?) was failing with this error, so deleting everything after that should produce a reproducible example (failing in 6.1.18, succeeding in 6.1.19).

@milliams
Copy link
Contributor

@graipher Cheers. Indeed I can reproduce this in 6.1.17 and it is fixed in at least develop and apparently in 6.1.19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants