Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom first day of week #70

Closed
sndnv opened this issue Jan 6, 2021 · 2 comments · Fixed by #71
Closed

Add support for custom first day of week #70

sndnv opened this issue Jan 6, 2021 · 2 comments · Fixed by #71

Comments

@sndnv
Copy link
Contributor

sndnv commented Jan 6, 2021

Is your feature request related to a problem? Please describe.
I want to be able to allow users to select the first day of the week, regardless of the device's locale.

Describe the solution you'd like
MaterialDayPicker.firstDayOfWeek is already available but it is private; it should be made public and it should correctly update the picker when a new value is set.

Describe alternatives you've considered
I tried to set the value directly using reflection, however, the picker did not update as expected.

Additional context
n/a

@gantonious
Copy link
Owner

Thanks for your contribution. It should now be available in:

implementation 'ca.antonious:materialdaypicker:0.7.4'

@sndnv
Copy link
Contributor Author

sndnv commented Jan 6, 2021

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants