Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget checkbox settings not saving #1014

Closed
AmibeWebsites opened this issue Nov 19, 2015 · 5 comments
Closed

Widget checkbox settings not saving #1014

AmibeWebsites opened this issue Nov 19, 2015 · 5 comments

Comments

@AmibeWebsites
Copy link
Contributor

Any widget setting that is a checkbox is not being saved when the Apply button is clicked. An example is inserting a Ninja form in layouts, the correct form can be selected and applied from the dropdown however the checkbox to 'Display Title' remain unchecked.

This is happening in Wordpress 4.3.1 on Gantry5 versions 5.2.1 and 5.2.3

@w00fz w00fz added this to the 5.3.0 milestone Dec 21, 2015
@mahagr mahagr assigned w00fz and unassigned w00fz May 16, 2016
@newkind
Copy link
Contributor

newkind commented Jun 8, 2016

Marking this as important as it should finally get fixed and it is a blocker for using some widgets in Layout Manager.

Also we have a wp.org topic about this issue : https://wordpress.org/support/topic/can-not-switch-view-in-widget-gantry-5-hydrogen-theme?replies=7#post-8499108

@w00fz
Copy link
Member

w00fz commented Jun 8, 2016

👍
Sorry, I actually did start looking at it the other day and then more pressing stuff came up. I'll look into it today.

// Djamil Legato // From iPhone //

On Jun 8, 2016, at 04:48, NewKind notifications@github.com wrote:

Marking this as important as it should finally get fixed and it is a blocker for using some widgets in Layout Manager.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub, or mute the thread.

@newkind
Copy link
Contributor

newkind commented Jun 8, 2016

Awesome! :) Thanks!

@w00fz w00fz closed this as completed in ed97c4e Jun 9, 2016
@w00fz
Copy link
Member

w00fz commented Jun 9, 2016

This is now fixed.

For the posterity's sake, the issue is that Ninja Forms uses a trick in their forms for checkboxes, where you render an hidden input field with value 0 and of the same name of the checkbox. This is a trick that allows to always submit in the form that name, because unchecked checkboxes are never sent. It allows to have always a name: 0 (hidden field) or name: 1 (checkbox) (reference).

I have now implemented a workaround to take this checkbox approach into account.

Also to keep in mind that we have still an outstanding issue (#677) where some widgets who have custom css/js are not properly working. That issue still remains for the moment.

@AmibeWebsites
Copy link
Contributor Author

Thank you - greatly appreciate what you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants