Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gantry 5.5.17 | Mobile Menu #3198

Closed
Dave-Skye opened this issue Oct 31, 2023 · 13 comments
Closed

Gantry 5.5.17 | Mobile Menu #3198

Dave-Skye opened this issue Oct 31, 2023 · 13 comments
Assignees
Labels

Comments

@Dave-Skye
Copy link

The mobile menu toggle does not seem to be working after upgrading to the latest gantry version.

Anyone else having this problem?

Gantry 5.5.17 with Hydrogen.

@hexplor
Copy link
Collaborator

hexplor commented Oct 31, 2023

Can you provide a link to your website? Working on my install.

@N8Solutions
Copy link

@Dave-Skye it's working for me. I'm using the Hydrogen template. What template are you using?

@Hotrods007
Copy link

Hotrods007 commented Nov 2, 2023

I see this to be the case only when adjusting the desktop view to mobile size... There is no hamburger. but On the Phone there is..

Gantry 5.5.17 Fluent Theme..
PHP 8.1.25

@hexplor
Copy link
Collaborator

hexplor commented Nov 2, 2023

Correct. I just noticed that as well.

@hexplor hexplor self-assigned this Nov 2, 2023
@hexplor hexplor added the bug label Nov 2, 2023
@hexplor hexplor reopened this Nov 3, 2023
@sdotter
Copy link

sdotter commented Nov 4, 2023

Fixed it temporary changing

attachMutationEvent: function () { this.offcanvas instanceof Node && new MutationObserver(this.bound("_checkTogglers")).observe( this.offcanvas, { childList: !0, subtree: !0 } ); },

to

attachMutationEvent: function () { this.offcanvas.on( "DOMSubtreeModified", this.bound("_checkTogglers") ); },

and

detachMutationEvent: function () { this.offcanvas instanceof Node && new MutationObserver(this.bound("_checkTogglers")).disconnect(); },

to

detachMutationEvent: function () { this.offcanvas.off( "DOMSubtreeModified", this.bound("_checkTogglers") ); },

@dagroupinc
Copy link

Will be fixed in a future release?

@paulinohio
Copy link

paulinohio commented Nov 9, 2023

sdotter: What directory are you changing this in?

@hexplor
Copy link
Collaborator

hexplor commented Nov 21, 2023

This should be fixed in CI builds (generating right now). Please let me know if the fix works for you. Thank you so much for your feedback.
Link here: https://gantry.org/downloads#ci-builds

@paulinohio
Copy link

Forgive my ignorance but do I just install the CI Builds like would any extension?

@N8Solutions
Copy link

Forgive my ignorance but do I just install the CI Builds like would any extension?

@paulinohio,
Yes, that is exactly what you do. Just like you were installing an update manually for Gantry 5. However, you should always take a backup first, and preferably do this on a staging/test site if at all possible. This way if things do blow up you can always restore quickly and if its not that bad you can simply reinstall the most recent stable version which in this case is v5.5.17.

@paulinohio
Copy link

Even after the update, the menu does not appear for me when adjusting the desktop view to mobile size. After I resize the page, I have refresh it in order for the hamburger menu to appear. I've tried this in many browsers.

@kolomvosg
Copy link

I had the same problem at a Joomla 4.4.1 site Gantry 5.5.17 and both Hydrogen 5.5.17.
I download the CI builds from https://gantry.org/downloads#ci-builds as hexplor suggested and installed it (over the installed Gantry 5.5.17) at my Joomla site and it worked immediatly. So now when i modify the width of the browser then the mobile menu (three lines) appears.

@paulinohio
Copy link

I installed it again and it works fine. Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants