-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement way to add wrapper divs and elements around multiple sections #548
Comments
See also #521 |
I like that and it would be great if we can choose the wrapper tag between div or section tag, because if we have a section without h1-h6 headings it is better to use divs instead of section because sections needs a heading semantically ( for more about this see https://www.w3.org/wiki/HTML/Usage/Headings/Missing ) I quoted << As a general rule, include a heading (h1-h6) as a child of each section and article element. >> |
Here is updated version of the file format: version: 2
preset:
name: test
image: 'gantry-admin://images/layouts/default.png'
layout:
wrapper-header-wrapper:
/header/:
- [logo 20, position-0 80]
/navigation/:
- menu
/grid-main-wrapper/:
- sidebar 20:
- position-7
- position-4
- position-5
- main 60:
- position-2
- position-12
- system-messages
- system-content
- aside 20:
- position-6
- position-8
- position-3
/footer/:
- [position-9 30, position-10 40, position-11 30]
- position-14
offcanvas:
- mobile-menu The format is almost the same as previously, but I tried to simplify it a bit. Having Green text (keys) defines the structure and blue text (values) defines the content. For numeric ids you need to use format like Reserved words for the structure (keys) are: In order to fully configure structure and content, there are also 2 other sections which allows people (and layout manager) to individually configure each element in the layout. They are split into two sections with flat data: |
So, no more container, i really like that you can set a One more. Could not all this options be added, like this?
I know this is the simplified version of the layout, but the full layout, is a bit too complex, you will lose your head when you need to add those rows and blocks. Would be really cool to have something similar to particle yaml format in simplified version. |
+1 to @adi8i 's comment about the class. That would be awesome! |
I didn't write the second part of the yaml file into my first message, but I've already thought on how to do what @adi8i suggests. I disagree and agree with the proposal -- I don't think that the main structure should contain every possible parameter as we would just end up having the complex syntax which we have right now coming from layout manager. Instead of that I would split the file into 3 parts where:
|
Sounds great @mahagr. |
There needs to be a way to easily add one or more wrapper divs or elements around multiple sections. This would most likely be best achieved through the yaml syntax and does not necessarily need to be represented in the layout manager UI as it would be simply for providing divs to target with css. Some sort of line and indentation to indicate that this named line would become
The text was updated successfully, but these errors were encountered: