forked from Mogara/QSanguosha
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
found bug in QSanInvokeSkillDock::update() #2
Comments
Thank you for your feedback. at: src\ui\qsanbutton.h L144: update(); |
I think this solution is safer and easier to read. Thanks for your feedback again. |
最后决定在我的分支中用 @gaodayihao 的方案了 |
都没用…………因为都有点笨…………: ) |
为什么? 55555555555555555~~~~~~~~~~~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I found bug in QSanInvokeSkillDock::update()
at src/ui/qsanbutton.cpp L390 : " int btnWidth = _m_width / btnNum[i] "
program crashed when btnNum[i] equals zero.
it will happen when player lost all skills.
I fixed the bug in this commit:
https://github.com/hejun442001/QSanguosha/commit/686129feb5c0ca35dced20e9bf4b026c9c3a0bdc
(btw: I cannot send pull request to this project, so I send this issues)
The text was updated successfully, but these errors were encountered: