Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Notebook integration #64

Closed
maartenbreddels opened this issue Dec 14, 2020 · 3 comments
Closed

Jupyter Notebook integration #64

maartenbreddels opened this issue Dec 14, 2020 · 3 comments

Comments

@maartenbreddels
Copy link
Contributor

Have you thought about Jupyter notebook integration, similar to https://jiffyclub.github.io/snakeviz/ ?

@gaogaotiantian
Copy link
Owner

I think other people asked about Jupyter. There are several reasons that I have not done this(or made any effort towards it)

  • Personally I never use Jupyter
  • It requires chromium for the UI to work and the UI is super heavy
  • The UI shows in a standalone html, which may work with iframe, but I'm not sure
  • People who use Jupyter are generally less concerned about performance. When they do, it's often a numpy issue which VizTracer is not helpful

However, if someday someone comes up with a solution on Jupyter, I would love to check it out and investigate the possibility to make it official.

@gaogaotiantian
Copy link
Owner

As of now, I won't look into this issue, because I'm not using Jupyter. If someone looks at this and decides to move forward, please feel free to reopen this issue and comment on some steps or a prototype. I'm not against the idea of making it work on Jupyter.

@maartenbreddels
Copy link
Contributor Author

Example commit maartenbreddels/per4m@d6796ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants