-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RandomMatrix - name clash with other packages #352
Comments
Yes sure no problem. But Semigroups 3.0.? requires GAP 4.9 so should not be included in an earlier release. |
Thanks - specified that in gap-system/gap-distribution@b474df1 (what this file is doing is documented in https://github.com/gap-system/gap-distribution/blob/master/DistributionUpdate/PackageUpdate/README.md) |
There is a name clash: it defines RandomMatrix as a function, while GradedModules and MatricesForHomalg already define it as an operation. Reported to Semigroups authors here: semigroups/Semigroups#352
For now, I've temporary disabled Semigroups for tests in master branch in gap-system/gap-distribution@b0f1f90 |
This resolves Issue semigroups#352 which highlighted a name clash with some other packages.
This resolves Issue #352 which highlighted a name clash with some other packages.
This resolves Issue semigroups#352 which highlighted a name clash with some other packages.
Resolved by PR #359. |
semigroups/Semigroups#352 fixed in Semigroups 3.0.5
Semigroups now defines
RandomMatrix
as a function. However, some other packages (namely GradedModules and MatricesForHomalg, already in GAP 4.8.7 release) define it as operation. Therefore, if any of those packages is loaded, then it's not possible to load Semigroups:I think this could have been discovered earlier by running
make testinstall
which will run testinstall twice, with only needed packages and with loading all packages.Would you be able to fix this and make a new release of Semigroups, please?
The text was updated successfully, but these errors were encountered: