Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomMatrix - name clash with other packages #352

Closed
olexandr-konovalov opened this issue Jul 29, 2017 · 4 comments
Closed

RandomMatrix - name clash with other packages #352

olexandr-konovalov opened this issue Jul 29, 2017 · 4 comments
Assignees

Comments

@olexandr-konovalov
Copy link
Contributor

Semigroups now defines RandomMatrix as a function. However, some other packages (namely GradedModules and MatricesForHomalg, already in GAP 4.8.7 release) define it as operation. Therefore, if any of those packages is loaded, then it's not possible to load Semigroups:

#I  Semigroups: start reading file 'init.g'
Error, BIND_GLOBAL: variable `RandomMatrix' must be unbound called from
BIND_GLOBAL( name, NEW_OPERATION_ARGS( name ) 
 ); at /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/GAPCOPTS/64\
build/GAPGMP/gmp/GAPTARGET/packagesload/label/kovacs/GAP-pkg-update-stable-sna\
pshot/lib/oper.g:1686 called from
<function "DeclareGlobalFunction">( <arguments> )
 called from read-eval loop at line 
77
  of /data/gap-jenkins/workspace/GAP-pkg-update-stable-quicktest/GAPCOPTS/64bu\
ild/GAPGMP/gmp/GAPTARGET/packagesload/label/kovacs/GAP-pkg-update-stable-snaps\
hot/pkg/semigroups-3.0.4/gap/elements/semiringmat.gd
you can 'quit;' to quit to outer loop, or
you can 'return;' to continue
brk> 

I think this could have been discovered earlier by running make testinstall which will run testinstall twice, with only needed packages and with loading all packages.

Would you be able to fix this and make a new release of Semigroups, please?

@james-d-mitchell
Copy link
Collaborator

Yes sure no problem. But Semigroups 3.0.? requires GAP 4.9 so should not be included in an earlier release.

@olexandr-konovalov
Copy link
Contributor Author

olexandr-konovalov pushed a commit to gap-system/gap-distribution that referenced this issue Aug 1, 2017
There is a name clash: it defines RandomMatrix as a function,
while GradedModules and MatricesForHomalg already define it
as an operation. Reported to Semigroups authors here:
semigroups/Semigroups#352
@olexandr-konovalov
Copy link
Contributor Author

For now, I've temporary disabled Semigroups for tests in master branch in gap-system/gap-distribution@b0f1f90

@james-d-mitchell james-d-mitchell self-assigned this Aug 6, 2017
james-d-mitchell pushed a commit to james-d-mitchell/Semigroups that referenced this issue Aug 23, 2017
This resolves Issue semigroups#352 which highlighted a name clash with some other
packages.
james-d-mitchell pushed a commit that referenced this issue Aug 23, 2017
This resolves Issue #352 which highlighted a name clash with some other
packages.
This was referenced Aug 23, 2017
james-d-mitchell pushed a commit to james-d-mitchell/Semigroups that referenced this issue Aug 23, 2017
This resolves Issue semigroups#352 which highlighted a name clash with some other
packages.
@wilfwilson
Copy link
Collaborator

Resolved by PR #359.

olexandr-konovalov pushed a commit to gap-system/gap-distribution that referenced this issue Aug 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants