Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with reesmat.tst (orb+semigroups) #1860

Closed
olexandr-konovalov opened this issue Nov 6, 2017 · 3 comments
Closed

Problem with reesmat.tst (orb+semigroups) #1860

olexandr-konovalov opened this issue Nov 6, 2017 · 3 comments
Labels
kind: bug Issues describing general bugs, and PRs fixing them
Milestone

Comments

@olexandr-konovalov
Copy link
Member

This has been discussed in #1809 and was identified as a separate issue. When Semigroups package is loaded, the following diffs appear:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-tested-master-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/standard/label/kovacs/GAP-pkg-u\
pdate-master-snapshot/tst/teststandard/reesmat.tst:693
# Input is:
ForAll(enum, x-> x in U);
# Expected output:
true
# But found:
false
########
########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-tested-master-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/standard/label/kovacs/GAP-pkg-u\
pdate-master-snapshot/tst/teststandard/reesmat.tst:712
# Input is:
ForAll(enum, x-> x in UU);
# Expected output:
true
# But found:
false
########

As @markuspf points out, this maybe related to the breaking of hash functions for permutations in "orb" package after PR #1831 which make spermutations remember their inverses.

@olexandr-konovalov olexandr-konovalov added the kind: bug Issues describing general bugs, and PRs fixing them label Nov 6, 2017
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Nov 6, 2017
@wilfwilson
Copy link
Member

These diffs are present when I use the released version of Orb (4.7.6), but not when I use the master branch of Orb (which contains a fix for the hashing of permutations). So I think @markuspf is right, and this should disappear when the next version of Orb is released.

@olexandr-konovalov
Copy link
Member Author

Waiting for the new Orb then. One could see this problem when current Orb is loaded in the new Travis test here: https://travis-ci.org/gap-system/gap-docker-master-testsuite/jobs/299400942

This Travis test allows everyone (not only to those who can access Jenkins) to see how testinstall/standard/bugfix/extra behaves with no packages, with default packages, and with all packages loaded, using the GAP Docker container for the master branch with packages from the packages-master.tar.gz archive.

@olexandr-konovalov
Copy link
Member Author

Picked up new Orb (and Semigroups too) - now the test is back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

No branches or pull requests

2 participants