Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unqualified LoadPackage in tst/testbugfix/2023-10-18-SetDimension.tst #5561

Closed
james-d-mitchell opened this issue Jan 5, 2024 · 0 comments · Fixed by #5565
Closed

Unqualified LoadPackage in tst/testbugfix/2023-10-18-SetDimension.tst #5561

james-d-mitchell opened this issue Jan 5, 2024 · 0 comments · Fixed by #5565
Assignees

Comments

@james-d-mitchell
Copy link
Contributor

james-d-mitchell commented Jan 5, 2024

The package fining is loaded in the file testbugfix/2023-10-18-SetDimension.tst which causes this test to fail when fining isn't available, such as in:

https://github.com/semigroups/Semigroups/actions/runs/7423583401/job/20201324551?pr=970

This is in the master branch.

It doesn't seem very sensible to have tests in the main GAP repo that rely on non-mandatory packages being available, and this is the only instance in the tests (at least according to a quick grep). Everywhere else there's an if LoadPackage("blah") <> fail then in the test file, seems like it'd be a good idea to that here too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants