Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Build is still Failing to display translated Portions #116

Closed
milotype opened this issue Apr 14, 2023 · 6 comments
Closed

Website Build is still Failing to display translated Portions #116

milotype opened this issue Apr 14, 2023 · 6 comments

Comments

@milotype
Copy link
Contributor

The website is still failing to display all translated text.
See screenshots below, or switch the language of the website (for intance into Croatian) to see untranslated texts.

1. https://gaphor.org/hr/#about

about

2. https://gaphor.org/hr/download

download

3. https://gaphor.org/hr/tutorials

tutorials

4. https://gaphor.org/hr/discuss

discuss

5. https://gaphor.org/hr/contribute

contribute

@danyeaw
Copy link
Member

danyeaw commented Apr 15, 2023

Thanks @milotype for reporting this! It looks like some of the pages are failing to translate now, I'll take a look.

@danyeaw
Copy link
Member

danyeaw commented Apr 15, 2023

The filters of html and Markdown urls was causing the po4a to fail to translate portions of the pages with those things. The negative of this is that there is more of those things in the translation strings. Over time, we could look at trying to reduce this by using liquid tags or classes in Markdown.

This should be fixed by 5c41b9d, could you please verify?

@milotype
Copy link
Contributor Author

@danyeaw
Copy link
Member

danyeaw commented Apr 16, 2023

Hi @milotype, you need to translate those strings:

https://github.com/gaphor/gaphor.github.io/blob/main/po/site.hr.po#L445
https://github.com/gaphor/gaphor.github.io/blob/main/po/site.hr.po#L52

etc.

There are 26 untranslated strings for the Croation translation:
https://hosted.weblate.org/translate/gaphor/gaphor-github-io/hr/?q=state:%3Ctranslated

I also saw that Weblate was still locked, the translation components should be unlocked now.

@milotype
Copy link
Contributor Author

Hi @danyeaw, I've solved all ov the above mentioned stuff.

But the https://hosted.weblate.org/projects/gaphor/docs-gaphor-org/hr/ is still locked.

@danyeaw
Copy link
Member

danyeaw commented Apr 16, 2023

Should be unlocked now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants