Partial Revert: 1fac5b1 (single line from this commit)

The mentality behind the original change was twofold: If the JS SDK hadn't loaded yet, clicking the link would still start the Connecting process. Second, the user could copy the link, venture to it and initiate the Connecting process.

I am reverting this (perhaps temporarily) because of the first case: If the JS SDK hasn't loaded yet, it might be because facebook.js isn't being loaded (e.g. 404), or (as is the case fixed by 1fac5b1) facebook.js is included AFTER Facebook's JS SDK has completely loaded. Both of these cases are fatal for the login process: Special:Connect cannot continue without the JS SDK. Therefore, sending the user to this page will do no good.

Facebook/FacebookHooks.php

@@ -380,7 +380,7 @@ public static function PersonalUrls( &$personal_urls, &$title ) {
 			}
 			$personal_urls['facebook'] = array(
 				'text'   => wfMsg( 'facebook-connect' ),
-				'href'   => SpecialPage::getTitleFor('Connect')->getLocalUrl('returnto=' . $title->getPrefixedURL()),
+				'href'   => '#', # SpecialPage::getTitleFor('Connect')->getLocalUrl('returnto=' . $title->getPrefixedURL()),
 				'class'  => 'mw-facebook-logo',
 				'active' => $title->isSpecial( 'Connect' ),
 			);