Skip to content

Commit

Permalink
[PAP] Fixed playback: make sure to init m_fadeOutTriggered
Browse files Browse the repository at this point in the history
  • Loading branch information
@garbear
garbear committed Aug 28, 2011
1 parent 5a1a2a7 commit 5933160
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions xbmc/cores/paplayer/PAPlayer.cpp
View file
Expand Up @@ -278,6 +278,7 @@ bool PAPlayer::QueueNextFileEx(const CFileItem &file, bool fadeIn/* = true */)
si->m_samplesSent = 0;
si->m_stream = NULL;
si->m_volume = (fadeIn && m_crossFadeTime) ? 0.0f : 1.0f;
si->m_fadeOutTriggered = false;

if (si->m_decoder.TotalTime() < TIME_TO_CACHE_NEXT_FILE + m_crossFadeTime)
si->m_prepareNextAtSample = 0;
Expand Down

3 comments on commit 5933160

@CrystalP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can send gnif a pull request for that, seems reasonable.

@garbear
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special git voodoo I should know about? I browse to his repo on github, click "Fork and edit this file", add the line with the new browser-based editor and hit submit pull request. However, the PR gets sent to xbmc's main branch. Same result if I checkout, modify, commit, push, pull request.

@CrystalP
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little bit of github-fu.
You have to do all that from your repo in github so...
Create a local branch based on AE, add this commit, then push to github in your repo.
In github, switch to that branch in the UI, press the Pull Request button, and if I remember correctly you have to change the base repo/branch to send the PR to, because the default is not good.

Please sign in to comment.