Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simfile.convert: Stopgap for warp conversion #16

Closed
garcia opened this issue Jun 29, 2022 · 1 comment
Closed

simfile.convert: Stopgap for warp conversion #16

garcia opened this issue Jun 29, 2022 · 1 comment
Labels
bug
Milestone
2.1

Comments

@garcia
Copy link
Owner

garcia commented Jun 29, 2022

We should add a stopgap for simfiles with warp events (WARPS tags for SSC, negative BPMs / stops for SM) so that we don't produce invalid simfiles. The lack of a stopgap necessitated a patch in ITL 2022. At minimum we should throw an exception in this scenario.
@garcia garcia added this to the 2.1 milestone Jun 29, 2022
@garcia garcia added the bug label Jun 29, 2022
@garcia
Copy link
Owner Author

garcia commented Jul 1, 2022 •
edited

Fixed in b3cf643 on dev.

@garcia garcia closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
1 participant
@garcia