Skip to content

Commit

Permalink
fix(examples): fix typo in k8s example + fix comment (#5337)
Browse files Browse the repository at this point in the history
Co-authored-by: Shumail Mohyuddin <shumailmohyuddin@gmail.com>
  • Loading branch information
eysi09 and shumailxyz committed Nov 14, 2023
1 parent 453ed6a commit 098d59e
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion core/src/cloud/api.ts
Expand Up @@ -201,7 +201,8 @@ export class CloudApi {
/**
* Initialize the Cloud API.
*
* Returns null if the project is not configured for Garden Cloud or if the user is not logged in.
* Returns null if the user is not logged in.
*
* Throws if the user is logged in but the token is invalid and can't be refreshed.
*
* Optionally skip logging during initialization. Useful for noProject commands that need to use the class
Expand Down
3 changes: 2 additions & 1 deletion examples/k8s-deploy-shared-manifests/README.md
Expand Up @@ -19,7 +19,6 @@ type: kubernetes
name: api
source:
path: ../ # <--- We set the source path of the action to the root so that we can reference the manifest files

spec:
files:
- manifests/deployment.yaml
Expand All @@ -29,6 +28,8 @@ spec:
kind: Deploy
type: kubernetes
name: web
source:
path: ../ # <--- We set the source path of the action to the root so that we can reference the manifest files
spec:
files:
- manifests/deployment.yaml
Expand Down
Expand Up @@ -15,7 +15,7 @@ spec:
app: ${var.appName}
spec:
imagePullSecrets:
- name: ${var.imagePullSecret}
- name: ${var.imagePullSecretName}
containers:
- name: ${var.appName}
image: "${actions.build[var.appName].outputs.deployment-image-id}"
Expand Down
2 changes: 1 addition & 1 deletion examples/k8s-deploy-shared-manifests/project.garden.yml
Expand Up @@ -15,7 +15,7 @@ variables:
environments:
- name: local
variables:
imagePullSecretName: "" # <--- Not needed for local dev
imagePullSecretName: "fake-secret" # <--- Not needed for local dev
baseHostname: local.demo.garden
- name: remote
defaultNamespace: ${var.remoteEnvName}
Expand Down

0 comments on commit 098d59e

Please sign in to comment.