Skip to content

Commit

Permalink
fix(cloud): quick fix the "cloud create user" command
Browse files Browse the repository at this point in the history
I required field for the request payload was missing so the command
would fail.

This is just a quick fix that adds the field, but in general we need to:

- Update the api-types package
- Consider using the api client that ships with it
- Ensure we're testing Core and Cloud across versions
  • Loading branch information
eysi09 authored and vvagaytsev committed Oct 13, 2022
1 parent f6e7cfd commit 2a4a631
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions core/src/commands/cloud/users/users-create.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export class UsersCreateCommand extends Command<Args, Opts> {
const usersToCreate = Object.entries(users).map(([vcsUsername, name]) => ({
name,
vcsUsername,
serviceAccount: false,
}))
const batches = chunk(usersToCreate, MAX_USERS_PER_REQUEST)
// This pretty arbitrary, but the bulk action can create 100 users at a time
Expand Down

0 comments on commit 2a4a631

Please sign in to comment.