Skip to content

Commit

Permalink
fix(k8s): error when copying TLS secrets between namespaces
Browse files Browse the repository at this point in the history
  • Loading branch information
edvald committed Jun 30, 2019
1 parent 7bee9cf commit 623a72d
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions garden-service/src/plugins/kubernetes/secrets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { GetSecretParams } from "../../types/plugin/provider/getSecret"
import { SetSecretParams } from "../../types/plugin/provider/setSecret"
import { DeleteSecretParams } from "../../types/plugin/provider/deleteSecret"
import { KubernetesResource } from "./types"
import { pick } from "lodash"

export async function getSecret({ ctx, log, key }: GetSecretParams) {
const k8sCtx = <KubernetesPluginContext>ctx
Expand Down Expand Up @@ -110,8 +111,11 @@ export async function ensureSecret(api: KubeApi, secretRef: SecretRef, targetNam
return
}

delete secret.metadata.resourceVersion
secret.metadata.namespace = targetNamespace
// Make sure we don't copy generated attributes
secret.metadata = {
...pick(secret.metadata, ["name", "annotations", "labels"]),
namespace: targetNamespace,
}

await api.upsert("Secret", targetNamespace, secret)
}

0 comments on commit 623a72d

Please sign in to comment.