Skip to content

Commit

Permalink
fix(k8s): bad error message when failing to get build status
Browse files Browse the repository at this point in the history
  • Loading branch information
edvald committed Mar 11, 2021
1 parent 0c605f2 commit d8481b2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion core/src/plugins/kubernetes/container/build/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ export async function skopeoBuildStatus({
const res = err.detail?.result || {}

// Non-zero exit code can both mean the manifest is not found, and any other unexpected error
if (res.exitCode !== 0 && !res.stderr.includes("manifest unknown")) {
if (res.exitCode !== 0 && !res.stderr?.includes("manifest unknown")) {
const output = res.allLogs || err.message

throw new RuntimeError(`Unable to query registry for image status: ${output}`, {
Expand Down
2 changes: 1 addition & 1 deletion core/src/plugins/kubernetes/local/minikube.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export async function setMinikubeDockerEnv() {
try {
minikubeEnv = (await exec("minikube", ["docker-env", "--shell=bash"])).stdout
} catch (err) {
if ((<execa.ExecaError>err).stderr.includes("driver does not support")) {
if ((<execa.ExecaError>err).stderr?.includes("driver does not support")) {
return
}
throw err
Expand Down

0 comments on commit d8481b2

Please sign in to comment.