fix(local-mode): fixed some bugs in local mode config (#3311)

* fix(local-mode): fixed some bugs in local mode config

* Always erase the original container's command - it might not be recognized by a proxy container
* Always delete the startup probe to avoid potential timeout issues
* Always overwrite env variables and erase envFrom of a proxy container - credentials and another service-level env vars are not necessary to set up a reverse proxy
* Always erase all mounted devices and volumes in a proxy container
* Corrected port configuration in the example. Duplicate servicePorts are not allowed.

core/src/plugins/kubernetes/local-mode.ts

@@ -342,17 +342,20 @@ function patchSyncableManifest(
 
   // use reverse proxy container image
   targetContainer.image = k8sReverseProxyImageName
+  // erase the original container command, the proxy container won't recognize it
+  targetContainer.command = []
   // erase the original container arguments, the proxy container won't recognize them
   targetContainer.args = []
 
-  const extraEnvVars = prepareEnvVars(localModeEnvVars)
-  if (!targetContainer.env) {
-    targetContainer.env = []
-  }
-  // prevent duplicate env vars
-  const extraEnvVarNames = new Set(extraEnvVars.map((v) => v.name))
-  remove(targetContainer.env, (v) => extraEnvVarNames.has(v.name))
-  targetContainer.env.push(...extraEnvVars)
+  // overwrite env vars of the proxy container,
+  // it needs only some specific variables to make reverse proxy work
+  targetContainer.env = prepareEnvVars(localModeEnvVars)
+  // ignore envFrom if any defined
+  targetContainer.envFrom = []
+
+  // remove all mounted volumes and devices from the proxy container
+  targetContainer.volumeMounts = []
+  targetContainer.volumeDevices = []
 
   if (!targetContainer.ports) {
     targetContainer.ports = []

examples/local-mode/backend-1/garden.yml

@@ -26,9 +26,6 @@ services:
         containerPort: 8080
         # Maps service:80 -> container:8080
         servicePort: 80
-      - name: http2
-        containerPort: 8000
-        servicePort: 80
     ingresses:
       - path: ${var.ingressPath}
         port: http # http2 can be used as an alternative port here