Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes modules fail when manifest kind is List #2011

Closed
padamson-r7 opened this issue Aug 20, 2020 · 3 comments
Closed

Kubernetes modules fail when manifest kind is List #2011

padamson-r7 opened this issue Aug 20, 2020 · 3 comments

Comments

@padamson-r7
Copy link

padamson-r7 commented Aug 20, 2020

Bug

Current Behavior

deploying a kubernetes module that uses List kind will throws this error:

Failed getting status for service 'spring-config-watcher' (from module 'spring-config-watcher'). Here is the output:
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Cannot read property 'namespace' of undefined
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Reproducible example

kind: Project
name: temp
environments:
- name: local
  providers:
  - name: local-kubernetes
    setupIngressController: false

---
  kind: Module
  type: kubernetes
  name: spring-config-watcher
  files: [spring-config-watcher.yml]

where the manifest is of kind List:

---
apiVersion: v1
kind: List
items:
  - apiVersion: v1
    kind: Service
    metadata:
...

The full manifest I was using is here:
https://docs.spring.io/spring-cloud-kubernetes/docs/2.0.0-M3/reference/html/#deployment-yaml

Workaround

refactor the List into a multi-document yaml file

(garden 0.12.2)

@thsig thsig self-assigned this Aug 24, 2020
@stale
Copy link

stale bot commented Oct 23, 2020

This issue has been automatically marked as stale because it hasn't had any activity in 60 days. It will be closed in 14 days if no further activity occurs (e.g. changing labels, comments, commits, etc.). Please feel free to tag a maintainer and ask them to remove the label if you think it doesn't apply. Thank you for submitting this issue and helping make Garden a better product!

@stale stale bot added the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Oct 23, 2020
@eysi09 eysi09 added the bug label Nov 5, 2020
@stale stale bot removed the stale Label that's automatically set by stalebot. Stale issues get closed after 14 days of inactivity. label Nov 5, 2020
@thsig thsig removed their assignment Apr 14, 2022
@thsig
Copy link
Collaborator

thsig commented May 31, 2022

This should be a simple fix—we'd be happy to provide some guidance for a contributor to get started with a PR for this.

@vvagaytsev
Copy link
Collaborator

This was fixed in #4501. Closing as a duplicate of #4500.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants