improvement(container): configurable deployment strategy #3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes are backwards compatible. The compatibility is ensured by the default values of the new configuration entry `deploymentStrategy`. The default value is "RollingUpdate". Validation ensures the informative error messages.
The new config option is still marked as required, despite there is a default value. Haven't found a way to mark it as an optional in the generated docs.
vvagaytsev
commented
Oct 10, 2022
| @@ -742,6 +747,11 @@ const containerServiceSchema = () => | |||
| ), | |||
| addCapabilities: containerAddCapabilitiesSchema("service"), | |||
| dropCapabilities: containerDropCapabilitiesSchema("service"), | |||
| deploymentStrategy: joi | |||
There was a problem hiding this comment.
The compatibility is ensured by the default value here.
The default value is "RollingUpdate".
Validation ensures informative error messages.
vvagaytsev
commented
Oct 10, 2022
| @@ -134,6 +138,7 @@ export interface ContainerServiceSpec extends CommonServiceSpec { | |||
| tty?: boolean | |||
| addCapabilities?: string[] | |||
| dropCapabilities?: string[] | |||
| deploymentStrategy: DeploymentStrategy | |||
There was a problem hiding this comment.
This field is not optional, but the changes are backward compatible. There is a default value supplied by the validator, see the comment below.
I had to modify the tests, but it's better to prefer doing extra modifications in tests instead of having an optional field and extra (in fact, redundant) default value logic in the production code.
|
Converted to draft, there are some test failures. |
Orzelius
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR makes the deployment strategy configurable for
containermodule type.Which issue(s) this PR fixes:
Fixes #3237
Special notes for your reviewer:
Please check my comments in the change set.