fix(local-mode): fixed some bugs in local mode config #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/local-mode-configs
branch
from
d04dacf
to
7e81e96
Compare
* Always erase original container's command - it might not be recognized by a proxy container * Always delete startup probe to avoid potential timeout issues * Always overwrite env variables and erase envFrom of a proxy container - credentials and another service-level env vars are not necessary to set up a reverse proxy * Always erase all mounted devices and volumes in a proxy container
Duplicate servicePorts are not allowed.
vvagaytsev
force-pushed
the
fix/local-mode-configs
branch
from
7e81e96
to
c503e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes some issues with a reverse proxy container startup in local mode. See the individual commits for details.
Which issue(s) this PR fixes:
Fixes #3284
Special notes for your reviewer: