fix: render (log) errors #4439
Merged
fix: render (log) errors #4439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if just the error was passed to the log entry it was not logged previously. This might have swallowed up quite a few errors in the past. Most of the time the error is formated into the `msg` on the log entry so I added logic that checks whether the entry already includes the the error and if so doesn't duplicate it.
The error detail is written to the error log file as it proved to be too noisy. That's why the error renderer was removed from the renderers in the first place.
vvagaytsev
reviewed
May 30, 2023
shumailxyz
approved these changes
May 30, 2023
Walther
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.
A bunch of test assertions might fail, will need to fix separately if so.
This also completes this https://github.com/orgs/garden-io/projects/5/views/1?pane=issue&itemId=28914020 <- was erroring out just as expected, it's just that the error was not shown.