Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helm module to action conversion: do not require version with name #4463

Merged
merged 3 commits into from May 30, 2023
Merged

fix: helm module to action conversion: do not require version with name #4463

merged 3 commits into from May 30, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented May 26, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4461

Special notes for your reviewer:
Validated locally using the example from the mentioned issue

gdev deploy
Deploy 🚀

Project is configured with `apiVersion: garden.io/v0`, running with backwards compatibility.
ℹ garden               → Running in Garden environment default.default
ℹ providers            → Getting status...
✔ providers            → Cached (took 0.7 sec)
ℹ providers            → Run with --force-refresh to force a refresh of provider statuses.
ℹ graph                → Resolving actions and modules...
✔ graph                → Done (took 0 sec)
ℹ deploy.mailhog       → missing
ℹ deploy.mailhog       → Deploying version v-68d2bc1af2...
ℹ deploy.mailhog       → Waiting for resources to be ready...
ℹ deploy.mailhog       → Resources ready
✔ deploy.mailhog       → Done (took 5.8 sec)

Done! ✔️

@Walther Walther requested a review from stefreak May 26, 2023 15:38
@Walther Walther requested a review from a team May 26, 2023 16:20
@stefreak
Copy link
Member

stefreak commented May 27, 2023 •
edited

@Walther Great work! Awesome that you fixed this one so quickly.

I think it would be good to also add a regression test

stefreak
stefreak approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@Walther Walther merged commit 947b911 into main May 30, 2023
36 of 38 checks passed
@Walther Walther deleted the helm-module-action-conversion-fix branch May 30, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefreak stefreak stefreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.13: [Bug]: Helm module: fails when version is not set
2 participants
@Walther @stefreak