New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add cloud secrets update command #4804
Conversation
633eafa
to
a1636e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation should also mention that secrets will be created if they don't exist.
If you want to make the creation of secrets default behavior the command should be upsert not update. If you want to keep it update I think that the creation of new secrets should be behind a flag, something like --upsert
.
Although we decided that we won't be testing this e2e with cloud I still think this code should be split into smaller testable parts and unit tests should be written to ensure quality and make future developments easier.
b0f88ac
to
6baa030
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Left a few comments but overall looks good.
198cfaa
to
fa2becd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the PR comments. Looks good to me!
What this PR does / why we need it:
Adds a new command to update secrets in cloud.
Which issue(s) this PR fixes:
Fixes #3079
Special notes for your reviewer:
upsert
to perform upsert and create missing secrets while updating existing secrets.update-by-id
to update secrets by id.scope-to-env
andscope-to-user-id
to perform scoped filtering.