Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore azure devops support for dockerhub images #4829

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Jul 13, 2023

What this PR does / why we need it:
We do not need an ENTRYPOINT, and azure devops only supports images
without it.

Which issue(s) this PR fixes:

Fixes #4818

Special notes for your reviewer:

We do not need an ENTRYPOINT, and azure devops only supports images
without it.

Fixes #4818
@stefreak
Copy link
Member Author

@ITHedgeHog is there anything else that comes to your mind that could cause incompatibilities with Azure DevOps, or should this change suffice?
It should make all images compatible with Azure Devops now, not just the garden-azure image.

@ITHedgeHog
Copy link
Contributor

That looks fine to me, we also used to have to add the following lines to our custom Garden image:

RUN apk add --no-cache --virtual .pipeline-deps readline linux-pam  \
  && apk add bash sudo shadow \
  && apk del .pipeline-deps

I've no idea if they're still required for the image to work on Azure DevOps - just providing them here in case they turn out to be necessary.

@stefreak
Copy link
Member Author

Thank you, good point! According to https://github.com/microsoft/azure-pipelines-agent/blob/master/docs/design/non-glibc-containers.md these would be required too. I'm adding this with a comment that it's for azure devops.

Copy link
Contributor

@worldofgeese worldofgeese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a default CMD?

support/buster.Dockerfile Show resolved Hide resolved
@worldofgeese worldofgeese self-requested a review July 24, 2023 08:58
@stefreak stefreak merged commit ef42b16 into main Jul 24, 2023
39 checks passed
@stefreak stefreak deleted the fix-azure-devops-support branch July 24, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Publish Docker images compatible with Azure Pipelines
3 participants