fix(template): respect project level variables in action config context #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regression was introduced in #4659. In that PR `this.variables` field was overwritten with the action-level values. It caused the erasure `this.variables = garden.variables` assignment in the super-class constructor.
Non-trivial test case with cross-context variable references. Uses disk-based project configuration. Involves the whole graph resolution.
vvagaytsev
force-pushed
the
feat/project-vars-in-include-exclude
branch
from
db55f1a
to
d48268d
Compare
shumailxyz
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The regression was introduced in #4659.
In that PR
this.variablesfield was overwritten with the action-level values. It caused the erasurethis.variables = garden.variablesassignment in the super-class constructor.Which issue(s) this PR fixes:
Fixes #4830
Special notes for your reviewer:
See individual commits. There is more explanation in the commit messages.