Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete pvc on namespace cleanup #4933

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: delete pvc on namespace cleanup #4933

merged 2 commits into from
Aug 11, 2023

Conversation

shumailxyz
Copy link
Contributor

@shumailxyz shumailxyz commented Aug 9, 2023

What this PR does / why we need it:
Add delete handler for pvc

Which issue(s) this PR fixes:
Fixes #1740

Special notes for your reviewer:

Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!
LGTM, but there are some lint errors, please double-check and fix 'em.

@shumailxyz
Copy link
Contributor Author

@vvagaytsev Fixed.

Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 👍

@vvagaytsev vvagaytsev merged commit f866c95 into main Aug 11, 2023
39 checks passed
@vvagaytsev vvagaytsev deleted the fix/delete-pvc branch August 11, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

garden del env can't finish
2 participants