feat: add ARM64 support #4947
Merged
feat: add ARM64 support #4947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Aug 15, 2023
core/src/plugins/octant/octant.ts
Outdated
| @@ -99,6 +99,7 @@ export const gardenPlugin = () => | |||
| targetPath: "octant_0.15.0_macOS-64bit/octant", | |||
| }, | |||
| }, | |||
| // this version has no arm support yet. If you add a later release, please add the "arm64" architecture. | |||
There was a problem hiding this comment.
Can we just update this now?
There was a problem hiding this comment.
Sure I can do that, but do we still support octant?
I thought we wanted to remove the dashboard but wasn't sure if that also applies to octant.
Also octant is no longer under active development and the repo has been archived.
There was a problem hiding this comment.
Oh I didn't realize that. In that case, just leave it. Let's mark the plugin as deprecated too.
There was a problem hiding this comment.
I gave it one last update to the last released version and marked it as deprecated.
|
Nice! ✨ Just had one very small comment, otherwise looks great. Thanks for taking this on 🙏 |
…ld is available and platform is arm
TimBeyer
force-pushed
the
feat/arm-support
branch
from
b400867
to
70dd605
Compare
edvald
previously approved these changes
Aug 15, 2023
edvald
previously approved these changes
Aug 15, 2023
edvald
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds ARM64 support for MacOS and Linux.
Not all dependencies are supported yet - specifically for the jib plugin on Linux - but those that are have been added.
It also updates the install script to pick the correct architecture, and it updates the self-updater to update to the ARM version when available and pick the AMD64 version otherwise.
Homebrew still requires an update to the formula to pick based on the architecture, but I believe we can do that separately which will also be a bit easier once the builds already exist. The homebrew formula is updated by a github action which doesn't support two different binaries right now, so that needs changes as well.
I have tested the ARM build for MacOS on MacOS and the Linux one inside a VM.
Which issue(s) this PR fixes:
Resolves #1547
Special notes for your reviewer: