improvement(plugins): debug log manifest dump #4997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this we were printing all the manifests we were applying at the verbose level which imo is too low a level and can make the logs very noisy. Noticed this e.g. when streaming logs via the dashboard.
stefreak
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
@eysi09 it was intentional, but I am also ok with the debug log level. Probably better, you're right.
The idea was that users can see what exactly has been applied when kubectl returns errors. I wonder if the manifests are part of the error details? Currently the error.log does not work, which is a bug I'll probably look into next
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this we were printing all the manifests we were applying at the verbose level which imo is too low a level and can make the logs very noisy.
Noticed this e.g. when streaming logs via the dashboard.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Assigning @stefreak since you added this. Not sure if it was intentional or not, but don't you agree that this should be debug as opposed to verbose?