fix: use shell matching platform when running scripts #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twelvemo
changed the title
mkhq
previously approved these changes
Sep 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mkhq
reviewed
Sep 7, 2023
| } | ||
|
|
||
| const scriptError = new WorkflowScriptError({ | ||
| message: `Script exited with code ${error.exitCode}`, | ||
| message: `Script exited with code ${err.detail.code}`, |
There was a problem hiding this comment.
yes, please keep using it! The ChildProcessError will still have details, the difference is that GardenError will simply not be a generic but the details are defined and typed in every single subclass of it that need them for use cases like this.
mkhq
approved these changes
Sep 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
runScript()function that is used to run script steps in workflows as well as theinitScriptwas directly shelling out via/bin/bash -swhich causes the script to be run in WSL on Windows. This can cause confusing behaviour because the commands needed in theinitScriptmight not be available in WSL e.g. clis to authenticate to cloud providers.This PR uses the
execwrapper and setsshell: truewhich causes execa to dynamically pick the right shell for the platform.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: