Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not error if actionSources are empty #5036

Merged
merged 1 commit into from Sep 7, 2023

Conversation

TimBeyer
Copy link
Contributor

@TimBeyer TimBeyer commented Sep 6, 2023

What this PR does / why we need it:
When there were no actionSources during a remote update, pMap was still called but the concurrency would have been set to 0.
That would cause an error and lead to it failing.
Now we only call the map if the actionSources are actually there.

Which issue(s) this PR fixes:

fixes #5035
Special notes for your reviewer:

Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast fix! 👍

@TimBeyer TimBeyer added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit bc38c97 Sep 7, 2023
41 checks passed
@TimBeyer TimBeyer deleted the fix/update-remote-concurrency branch September 7, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13: [Bug]: update-remote: --parallel flag broken
2 participants