Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(build): update moby/buildkit to v0.12.2 #5105

Merged
merged 2 commits into from Sep 20, 2023
Merged

improvement(build): update moby/buildkit to v0.12.2 #5105

merged 2 commits into from Sep 20, 2023

Conversation

highb
Copy link
Contributor

@highb highb commented Sep 18, 2023

What this PR does / why we need it:

This PR upgrades the moby/buildkit to v0.12.2, which, among other improvements, adds the --secret flag which will allow secrets to be mounted into buildkit builds without including them in the final image layers. This is a security improvement, as it helps prevent secrets from leaking out in the image layers, if used properly by end users.

Technically, the secrets flag was added in v0.12.0, but I am assuming that it would be a better use of everyone's time if we went directly to the most recent Z release.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@shumailxyz shumailxyz requested a review from a team September 19, 2023 08:53
Copy link
Contributor

@shumailxyz shumailxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the PR. ✨
Left a comment about updating the buildkit version in addition to updating the buildkit-rootless version.

images/buildkit/Dockerfile Show resolved Hide resolved
@vvagaytsev vvagaytsev changed the title chore: Update moby/buildkit to v0.12.2 improvement(build): update moby/buildkit to v0.12.2 Sep 19, 2023
Copy link
Contributor

@shumailxyz shumailxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @highb

@vvagaytsev vvagaytsev added this pull request to the merge queue Sep 20, 2023
Merged via the queue into garden-io:main with commit 5faac9e Sep 20, 2023
18 checks passed
@highb highb deleted the update-builtkit-v0-12-2 branch September 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants