Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(git): don't require Garden static dir to be a Git repo #5120

Merged
merged 3 commits into from Nov 9, 2023

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Sep 21, 2023

What this PR does / why we need it:
This is a subset of the changes from #4047. The original PR is quite old and requires some conflict resolution.
This PR brings a quick win to improve the usability of Garden.

Which issue(s) this PR fixes:

Fixes #2614
Fixes #4476
Fixes #4477
Fixes #5030

Special notes for your reviewer:
Depends on #5136

@vvagaytsev vvagaytsev requested review from edvald, eysi09 and a team September 21, 2023 09:40
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🥳

Can you remove git init in the following places in this PR, to verify that garden really works without git in the static directory in our e2e tests:

@vvagaytsev
Copy link
Collaborator Author

Good catch, @stefreak! Thank you so much! I'll double-check the rest pieces of the existing code.

@vvagaytsev
Copy link
Collaborator Author

@stefreak I've addressed the comments above in a686596. Please check this again. I haven't found any other places where we init git repo for static dirs.

@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from a686596 to 8352f78 Compare September 25, 2023 11:07
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from 8352f78 to 56e7fae Compare September 26, 2023 07:28
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch 2 times, most recently from c89b356 to dda945c Compare October 5, 2023 18:34
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from dda945c to 036fd8f Compare October 13, 2023 10:48
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch 2 times, most recently from 6f1af5e to 63d00c6 Compare October 24, 2023 17:42
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from 63d00c6 to b7d3c9b Compare November 2, 2023 09:43
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from b7d3c9b to 0d3ff1d Compare November 9, 2023 12:46
@vvagaytsev vvagaytsev requested review from stefreak and removed request for stefreak November 9, 2023 13:45
@vvagaytsev vvagaytsev force-pushed the refactor/remove-unused-vcs-code branch from 0d3ff1d to 997ea6f Compare November 9, 2023 14:05
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🥳

@vvagaytsev vvagaytsev added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit dc8ba20 Nov 9, 2023
45 checks passed
@vvagaytsev vvagaytsev deleted the refactor/remove-unused-vcs-code branch November 9, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants