fix(pulumi): return correct responses for pulumi plugin commands #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefreak
reviewed
Sep 23, 2023
shumailxyz
force-pushed
the
pulumi-undefined-err
branch
from
ff4bdac
to
c9ee1ac
Compare
this enforces responses of type ValidResultType for the pulumi plugin commands for actions.
shumailxyz
force-pushed
the
pulumi-undefined-err
branch
from
c9ee1ac
to
6137b7b
Compare
shumailxyz
changed the title
stefreak
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Awesome work @shumailxyz!
I'd love to see tests for this, but as the pulumi provider is still flagged as experimental I am ok with this as-is; it's already a big improvement and will help catch this class of bugs during compilation.
|
Totally agreed. We have a separate issue #4600 to track tests for pulumi, should consider prioritizing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This enforces responses of type ValidResultType for the pulumi plugin commands for actions. Previously, the plugin commands for actions were not returning anything, resulting in runtime errors. The TS compiler didn't catch these due to the pulumi plugin command responses typed as
any.Which issue(s) this PR fixes:
Fixes #5118
Fixes #5084
Special notes for your reviewer: