fix: memoize memory leak #5137
Merged
fix: memoize memory leak #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memoize was using an object as a cache key whose identity kept changing. Thus it never returned a cache hit and kept storing new objects in cache. With this fixed, memory consumption becomes a lot more reasonable, plus the cache actually yields the desired performance benefits.
TimBeyer
force-pushed
the
fix/memoize-memory-leak
branch
from
f95dd1a
to
a51046c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Memoize was using an object as a cache key whose identity kept changing. Thus it never returned a cache hit and kept storing new objects in cache. With this fixed, memory consumption becomes a lot more reasonable, plus the cache actually yields the desired performance benefits.
Which issue(s) this PR fixes:
Fixes #4638
Special notes for your reviewer: