fix(k8s): use yaml 1.1 when reading kubernetes manifests #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also kubernetes/kubernetes#34146 (Kubernetes manifest files are still using yaml 1.1)
stefreak
force-pushed
the
kubernetes-yaml-1.1
branch
from
4bfe9f1
to
8eadd53
Compare
TimBeyer
approved these changes
Oct 5, 2023
shumailxyz
approved these changes
Oct 5, 2023
vvagaytsev
approved these changes
Oct 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
stefreak
added a commit
that referenced
this pull request
Oct 19, 2023
Kubernetes only supports YAML 1.1, and we recently fixed a bug to read kubernetes manifests using the correct YAML version (#5184) We accidentally did not update the example to use the old-style octal numbers. Searching for `0o` gives no further results at least in the garden repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Correctly read kubernetes manifests in kubernetes deploy action using YAML 1.1 spec.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
See also kubernetes/kubernetes#34146
(Kubernetes manifest files are still using yaml 1.1)