fix(core): ensure needsReload flag works #5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a function, not a boolean we were evaluating so it always returned true. This fixes that.
TimBeyer
previously approved these changes
Oct 9, 2023
stefreak
requested changes
Oct 9, 2023
core/src/server/server.ts
Outdated
| @@ -892,7 +892,7 @@ export class GardenServer extends EventEmitter { | |||
| } catch (error) { | |||
| errors.push(toGardenError(error)) | |||
| } finally { | |||
| loadConfigLog.success(`Loading config failed with error: ${errors[0].message}`) | |||
| loadConfigLog.error(`Loading config failed with error: ${errors[0].message}`) | |||
There was a problem hiding this comment.
Isn't it possible that errors is empty when the interpreter runs this line of code?
The finally block will run even when no error has been catched in this try/catch clause.
There was a problem hiding this comment.
Is it possible that this line of code should be above the line 894?
There was a problem hiding this comment.
Good catch, revoking my approval 😅
There was a problem hiding this comment.
Haha on closer inspection this code doesn't make sense at all. I just noticed we were using success to print something that looked like an error but didn't look at the overall flow. My intention I was basically just to fix a typo.
I'll update though.
stefreak
reviewed
Oct 9, 2023
| @@ -236,7 +236,7 @@ export class GardenInstanceManager { | |||
|
|
|||
| // Flag the instance for reloading when configs change | |||
| garden.events.once("configChanged", (_payload) => { | |||
| if (!garden.needsReload) { | |||
| if (!garden.needsReload()) { | |||
stefreak
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
That's a function, not a boolean we were evaluating so it always returned true. This fixes that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: