fix: allow generated files in build actions #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the container and jib-container build actions, we checked for the existance of files checked in to version control for certain checks. Garden allows for files to be injected into the build action dynamically at run time, e.g. by using `copyFrom` and `generateFiles`. We want to check for actual presence of files in the action's build directory instead of checking for the files that are included from version control. Fixes #5201
mkhq
approved these changes
Oct 11, 2023
|
Thanks for the extensive comments 👍 |
|
Hey guys, could this be implemented for deploy actions as well? |
|
@hassinerhouma Thanks for the report, I got back to you in #4964 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the container and jib-container build actions, we checked for the
existance of files checked in to version control for certain checks.
Garden allows for files to be injected into the build action dynamically
at run time, e.g. by using
copyFromandgenerateFiles.We want to check for actual presence of files in the action's build
directory instead of checking for the files that are included from
version control.
Which issue(s) this PR fixes:
Fixes #5201
Special notes for your reviewer: