fix(cli): exit code 1 on unknown commands, sub-commands and flags #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/4911
branch
2 times, most recently
from
799a0f1
to
b6d9086
Compare
vvagaytsev
changed the title
vvagaytsev
force-pushed
the
fix/4911
branch
5 times, most recently
from
90d6d1b
to
57db35a
Compare
stefreak
previously approved these changes
Oct 16, 2023
|
One comment on the plan to backport this to 0.12: Do we have to do that? I think it might not be important enough to justify the effort (But I might be wrong, you might have good reasons). |
It's not super critical, but it might be better to align the exit code behavior between 0.12 and 0.13. The back-port should be a big effort. We're going to do the next |
Handle `--help` flag separately.
stefreak
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR brings strict consistency into Garden command exit codes and fixes the possible CI problems like the ones we got in #4868.
Which issue(s) this PR fixes:
Fixes #4911
Special notes for your reviewer:
This PR has been done in TDD mode :)
The test specs were written first.
To be back-ported to0.12.TODOs (to be addressed in a separate PR):