fix(k8s): correct 0.12 => 0.13 service resource conversion
#5272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
fix/5269
branch
2 times, most recently
from
c7e9586
to
4b34f44
Compare
twelvemo
previously approved these changes
Oct 19, 2023
shumailxyz
suggested changes
Oct 19, 2023
There was a problem hiding this comment.
Thanks @vvagaytsev Fix looks great, but the tests are failing. Please check that.
twelvemo
reviewed
Oct 19, 2023
|
@twelvemo @shumailxyz thank you! I've pushed the test fixes in the most recent commit. Let's wait for the CI completion. |
twelvemo
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR ensures the the module conversion respects the 0.13 schema validation rules, which are now stricter than in 0.12.
Which issue(s) this PR fixes:
Fixes #5269
Special notes for your reviewer:
A new function
convertServiceResourceSpecwas extracted to take more specific input parameters and to do the spec-to-spec conversion. This also allowed making the unit test data preparation way easier.