Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): print warning message if docker server version is unparsab… #5288

Merged
merged 1 commit into from Oct 23, 2023

Conversation

AmauryD
Copy link
Contributor

@AmauryD AmauryD commented Oct 21, 2023

What this PR does / why we need it:

In some rare cases, the Docker server version might return 'dev,' which could trigger a crash during version parsing. This pull request addresses this issue by only emitting a warning message when the version cannot be parsed.

Which issue(s) this PR fixes:

Fixes #5284

Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thank you for contributing this @AmauryD

Especially the unit test is awesome 👏

@stefreak stefreak added this pull request to the merge queue Oct 23, 2023
Merged via the queue into garden-io:main with commit 5f92abd Oct 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: Invalid version. Must be a string. Got type "object" while checking docker server version.
2 participants