fix(cloud): do not fetch secrets on community tier #5291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we'd log a warning about secrets not existing for users on the community tier when in fact we shouldn't be attempting to fetch them in the first place.
eysi09
force-pushed
the
skip-fetching-secrets-on-community-tier
branch
from
07c344b
to
b3350f9
Compare
eysi09
added a commit
that referenced
this pull request
Oct 26, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Oct 27, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Oct 27, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Oct 27, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Oct 27, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Oct 31, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Nov 1, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Nov 1, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
eysi09
added a commit
that referenced
this pull request
Nov 1, 2023
This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
* fix(cloud): ensure cloud project id is set on garden class This commit fixes a regression introduced with: #5291 That commit was just a tiny tweak to a couple of lines of code to improve error messages but actually ended up breaking the core <> cloud interaction for the community tier dashboard. The underlying reason is the fact that this particular code was quite convoluted and not tested well enough. So this commit refactors the cloud init logic to make it more readable and adds a handful of tests to prevent these kind of regressions from happening again. * improvement(cloud): better errors when fetching project fails * fix(core): ensure id and domain are set even if user isn't logged in A previous commit in the same PR changed this behaviour. This simply reverts it back to what it was. * chore: fix tests (TBS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we'd log a warning about secrets not existing for users on the community tier when in fact we shouldn't be attempting to fetch them in the first place.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: