fix(k8s): return deployed mode in container Deploy status #5302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we were returning the action mode (e.g. `default`, `sync` or `local`) set on the locally generated manifests under `status.detail.mode` for `container` Deploys. This meant that e.g. the `get status` command would always show the mode as `default`. The fix was to use the action mode set on the deployed resources, like we've been doing for `kubernetes` and `helm` Deploys. Also added an integ test case for this behavior.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we were returning the action mode (e.g.
default,syncorlocal) set on the locally generated manifests understatus.detail.modeforcontainerDeploys.This meant that e.g. the
get statuscommand would always show the mode asdefault. The fix was to use the action mode set on the deployed resources, like we've been doing forkubernetesandhelmDeploys.Also added an integ test case for this behavior.
The usefulness of this fix is that it should allow the Cloud UI to rely on the action modes in deploy statuses to show e.g. the mode of Deploys in the graph view.