fix(helm): handle missing (null) values in version check #5307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ingress controller-specific issue reported in the target ticket will be resolved in #5136. However, the |
twelvemo
requested changes
Oct 27, 2023
Co-authored-by: Anna Mager <78752267+twelvemo@users.noreply.github.com>
twelvemo
requested changes
Oct 27, 2023
twelvemo
reviewed
Oct 27, 2023
| state = "outdated" | ||
| } else { | ||
| log.verbose(`No helm values returned for release ${releaseName}. Is this release managed outside of garden?`) |
There was a problem hiding this comment.
Shouldn't we log this when the values are null?
There was a problem hiding this comment.
Fixed this in 8605647.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #5303
Special notes for your reviewer: