fix(pulumi): propagate resolved action context to pulumi plugin commands #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
previously approved these changes
Oct 31, 2023
plugins/pulumi/src/commands.ts
Outdated
| const actions = graph.getDeploys({ names }).filter((a) => a.type === "pulumi") | ||
| // Provider resolution is a heavy operation. |
There was a problem hiding this comment.
Let's delete this comment—kf the providers have already been resolved on a garden instance, the resolved providers are cached.
There was a problem hiding this comment.
Removed in f8260ab.
Providers are already resolved and cached.
thsig
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the regressions introduced in
0.13. In0.12, references to${modules.*}in the Pulumi varfiles were possible.This PR fixes
0.13to use:${actions.*}references in Pulumi varfiles${modules.*}references with module-based configsWhich issue(s) this PR fixes:
Fixes #5083
Special notes for your reviewer: