Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pulumi): fix process dependency resolution in plugin command #5325

Merged
merged 1 commit into from Oct 31, 2023

Conversation

vvagaytsev
Copy link
Collaborator

What this PR does / why we need it:
Method resolveDependencies was unused before this fix. However, it was implemented to handle the process dependencies. This commit renames it to override the corresponding method of the parent class, as it was initially intended.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Method `resolveDependencies` was unused before this fix.
But, it was implemented to handle the process dependencies.
This commit renames it to override the corresponding method of the parent class,
as it was initially intended.
@vvagaytsev vvagaytsev requested review from thsig and a team October 31, 2023 14:21
Copy link
Contributor

@shumailxyz shumailxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Good catch ✨

@vvagaytsev vvagaytsev added this pull request to the merge queue Oct 31, 2023
Merged via the queue into main with commit d460f3f Oct 31, 2023
44 checks passed
@vvagaytsev vvagaytsev deleted the fix/run-pulumi-preview-in-dependency-order branch October 31, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants