Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle and retry DNS errors #5326

Merged
merged 4 commits into from Nov 1, 2023
Merged

fix: handle and retry DNS errors #5326

merged 4 commits into from Nov 1, 2023

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Oct 31, 2023 •
edited

What this PR does / why we need it:
DNS error codes are not included in the OS error constants
(os.constants) / https://nodejs.org/docs/latest-v18.x/api/os.html#error-constants

This PR adds DNS error codes to the list of handled errno errors.

Which issue(s) this PR fixes:

Fixes #5217

@stefreak stefreak mentioned this pull request Oct 31, 2023
Closed
@stefreak
Copy link
Member Author

stefreak commented Oct 31, 2023 •
edited

Also implemented a simple test now where we provoke some common NodeJS errors like ENOTFOUND and make sure we recognize them.

@stefreak
fix: handle DNS error codes as ErrnoException
2040ca2 
DNS error codes are not included in the OS error constants
(os.constants) / https://nodejs.org/docs/latest-v18.x/api/os.html#error-constants

This commit adds DNS error codes to the list of handled errno errors.

Fixes #5217
@stefreak stefreak mentioned this pull request Oct 31, 2023
Closed
@stefreak stefreak changed the title fix: handle DNS error codes as ErrnoException fix: handle DNS error codes in isErrnoException Oct 31, 2023
@stefreak stefreak changed the title fix: handle DNS error codes in isErrnoException fix: handle and retry DNS errors Oct 31, 2023
@stefreak stefreak requested a review from a team October 31, 2023 21:53
stefreak

This comment was marked as resolved.

Sign in to view

@stefreak stefreak added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit e1738ac Nov 1, 2023
44 checks passed
@stefreak stefreak deleted the fix-5217 branch November 1, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thsig thsig thsig approved these changes

@TimBeyer TimBeyer Awaiting requested review from TimBeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash: toKubernetesError encountered an unknown error unexpectedly during Kub...
2 participants
@stefreak @thsig