improvement(logger): some minor fixes #5475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
force-pushed
the
more-log-tweaks
branch
from
b4b3ea3
to
2120f9b
Compare
vvagaytsev
reviewed
Nov 23, 2023
core/src/tasks/resolve-provider.ts
Outdated
| const verboseLogProviders = ["templated", "container"] | ||
| const fixLevel = verboseLogProviders.includes(providerName) ? LogLevel.verbose : undefined | ||
| const debugLogProviders = ["templated", "container"] | ||
| const fixLevel = debugLogProviders.includes(providerName) ? LogLevel.silly : undefined |
There was a problem hiding this comment.
Should this be LogLevel.debug instead of LogLevel.silly?
eysi09
force-pushed
the
more-log-tweaks
branch
from
2120f9b
to
ffafc2b
Compare
eysi09
force-pushed
the
more-log-tweaks
branch
2 times, most recently
from
e76a5d9
to
b0f3f2c
Compare
Namely: - Setting logs for some built-in providers to debug because that's just more fitting - Do not print new line after resolving providers and graph. Doesn't render nicely. - Add an "init" log context for the Garden class that logs when Garden has been initialized with duration for non-dev commands. - Print link to Cloud at end of command run as well - DO NOT log outdated statuses at a "warning" level - Other minor tweaks
eysi09
force-pushed
the
more-log-tweaks
branch
from
b0f3f2c
to
640f1ba
Compare
vvagaytsev
approved these changes
Nov 24, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
From commit message:
improvement(logger): some minor fixes
Namely:
more fitting
render nicely.
has been initialized with duration for non-dev commands.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I know these keep raining in. My apologies. They're not super urgent per se and just small tweaks as I bump into more and more things while doing some content work.
I tend to push them immediately to keep my own content branch sane and rebased.